Re: submitting code
- Posted by useless Oct 01, 2009
- 1715 views
When you developed an ifdef to deal with the "compile as dll", and added that plus some to http.e (and i have no problems with you doing that), someone said that was "fixing" (or was it "correcting"?) my code. That's a complete mischaracterisation of what happened, and i feel that was an attack against me.
See, here is the problem. When you submit code to the Euphoria project, it is not your code. It's code that exists in the Euphoria project. And, in fact, net/http.e was broke! It would not compile into a DLL, thus, that code was broke. How much more broke does it need to be? Thus, I added a ifdef around the task_yield() to fix the code in Euphoria. I could care less who submitted it, who's code it was or who is trying to claim ownership. If Derek, Matt, Jim, CK or anyone else would have submitted that code and I then tried to use http.e in a DLL and found it wouldn't even compile, then I would have made the same correction and the same comment. And for the record, here is the commit log for the entry in question:
Revision 2666 - (view) (download) (annotate) - [select for diffs] Modified Mon Aug 31 13:01:54 2009 UTC (4 weeks, 3 days ago) by jeremy_c File length: 25603 byte(s) Diff to previous 2631 * Added ifdef EUC_DLL around task_yield() * Formatted a bit (mostly automated, so it's still not 100% right)
Regardless, if I had said Fixed, then I wouldn't care. And do you know what? If Matt, Derek, Jim, CK or anyone else would have submitted the original code when I added the word Fixed to the commit log, do you know what they would have said? Nothing!
Why is this so hard to understand? I'm getting pretty tired of this same old thing. Can you please just accept the fact that this is a community project, that not everything submitted is accepted, that not everything accepted was accepted as is and that not everything in Euphoria is going to remain exactly how it was yesterday and that any change to Euphoria is not a personal attack!
Jeremy
That's all fine and good, it's not MY code, yet Matt did say you fixed MY code, when in fact the problem was due to the task code not allowing the dll to compile properly. I did add task code to http.e, and sped it up considerably, and was adding task msging to it as well, making it even more multi-tasking-friendly. Matts tone was derisive, and implying it was all me that broke it, and there were no other factors, but i don't see it as my fault that a general lib (tasks) was not tested to be useable in a dll before it was added to core.
I am aware no code stays the same for long. AGAIN, i did not consider what you did to be an attack, i considered it code development and evolution. I did not complain about your fixes, they were valid. In fact, i was happy the code was staying in despite me "breaking" it, and a way was being sought to allow task.e to be useable in http.e. Can you please just accept this fact, or must this also be in contention forever?
Bruce, see what you get if you submit code and care enough about Euphoria to try to help develop it?
useless
