Re: Win32lib

new topic     » goto parent     » topic index » view thread      » older message » newer message

Thanks for this bug fix. You too Matt. There is a similar set of minor bugs
in many other structures too, in that they use Long instead of UInt and thus
return a signed 31-bit value instead of an unsigned 32-bit value.

I've fixed the fetch() and store() routines to treat UInt and Long correctly
too.

------
Derek Parnell
Melbourne, Australia
"To finish a job quickly, go slower."

----- Original Message -----
From: "Jess Harpur" <jach at blueyonder.co.uk>
To: "EUforum" <EUforum at topica.com>
Sent: Friday, May 11, 2001 4:24 AM
Subject: Win32lib


> >
>
> Hello,
>
> I'm usually just lurking but here's my contribution for what it's worth.
>
> -- Software ID: win32lib
> -- Version:     0.55.1 19/Dec/2000
>
> Line 1620 contains an error which results in SIZEOF_MSG being two bytes
> too few. Consequently acquire_mem(0, SIZEOF_MSG) grabs less memory than
> required and calls to GetMessage write past the end of the allocated
> memory with unpredictable results. If this has been fixed in a later
> version of the library then "good on yer" ;)
>
> -- Type MSG
>     msgHWnd      = allot( Long ),
>     msgMessage   = allot( Integer ), *** Should be allot( UInt )***
>     msgWParam    = allot( Long ),
>     msgLParam    = allot( Long ),
>     msgTime      = allot( DWord ),
>     msgPtX       = allot( Long ),
>     msgPtY       = allot( Long ),
>     SIZEOF_MSG   = allotted_size(),
>
> HTH.
>
> Jess
>
> >
> >
> >

new topic     » goto parent     » topic index » view thread      » older message » newer message

Search



Quick Links

User menu

Not signed in.

Misc Menu