OpenEuphoria

RE: Derek - Win32Lib V0.58.6

• Posted by Jonas Temple <jtemple at yhti.net> May 15, 2003
• 415 views

Derek Parnell wrote:
> > I thought the routine should be:
> >
> > --/topic ListView Control
> > --/proc insertLVColumn(id,index,mask,fmt,cx,text,iSubItem )
> > --/desc Inserts a new column into a listview control.
> > global procedure insertLVColumn( atom id, integer index,
> >                 atom mask, atom fmt, atom cx, object text, object
> > pColumn )
> >
> >     atom LV_COLUMN
> >
> >     LV_COLUMN = struct_LVCOLUMN( LVCF_SUBITEM, fmt, cx, text, pColumn )
> >
> >     VOID = sendMessage( id, LVM_INSERTCOLUMN, index - 1, LV_COLUMN)
> >
> >     release_mem( LV_COLUMN )
> >
> > end procedure
> >
> > Note the only change is "index - 1" instead of "pColumn - 1".
> >
> > Am I missing something?
> 
> Not really. The 'index' parameter is not used anymore. In reality I 
> should
> delete it but that might break some existing code.

In reality if anyone was using insertLVColumn in it's prior version 
their code is broken anyway.  

> 
> 
> What do people think? Can I remove this parameter?

I think since you're changing the routine and it will require us to 
review our code, go ahead and nuke it.

Jonas
>