OpenEuphoria

Re: Andy Serpa are you still around?

• Posted by don cole <doncole at pacbell.net> Jan 13, 2006
• 561 views

Andy Serpa wrote:
> 
> Al Getz wrote:
> > 
> > Andy Serpa wrote:
> > > 
> > > don cole wrote:
> > > > 
> > > > Andy Serpa wrote:
> > > > > 
> > > > > don cole wrote:
> > > > > > 
> > > > > > 
> > > > > > We found a slight bug in your nat_sort.e.
> > > > > > Post something on the forum if you want to know about it.
> > > > > > 
> > > > > 
> > > > > Oh yeah?
> > > > 
> > > > Check it out what do you think?
> > > 
> > > 
> > > Ahh yes, in the nat_compare_str() routine, x1num & x2num should be
> > > declared
> > > as atoms.  Looks like I changed it in my personal version but never fixed
> > > it.
> > >  If declared as integers than long strings of numbers can cause integer
> > >  overflow...
> > 
> > Hi there Andy,
> > 
> > 
> > Could you also check to see that a long name such as:
> >   "123456789012345678901234567890.jpg"
> > still works ok when you're done fixing it?
> > 
> > When i want to check something like this with an unusual name
> > i just create a text file in Win Explorer with whatever name
> > i want to test with and then see how the program handles it
> > when it is run.
> > 
> > 
> I only changed one line -- declared as atoms instead of integers.  So any long
> stream of digits that will successfully convert to an atom should work fine,
> meaning your filenames could be dozens of digits long.  It had nothing to do
> with decimal points because it ignores them anyway.


If you changed x1num, x2num from integers to atoms that would be 2 lines
wouldn't it? The integer line and the atom line.

Anyway thanks for fixing it Andy,

Don Cole
 A Bug is an un-documented feature.
A Feature is a documented Bug.