Re: Ping Derek: Eight potential bugs in win32lib

new topic     » goto parent     » topic index » view thread      » older message » newer message

Pete Lomax wrote:
> 
> Derek,
> None of these are known to cause any bugs, but I've noticed 8 cases
> where atoms are assigned to integers. Either the rhs is an atom so
> that it can hold 32 bits and therefore the lhs should be too, or the
> rhs should be wrapped in floor().
> 
> I'm posting this list for review/info only, in the hope of avoiding
> grief for you or one of your users at some future date.
> 
> I'm pretty sure the first one cannot possibly cause a problem, whereas
> in contrast I'm pretty sure 25680 is a bug waiting to happen.
> 

Good catch. Fixing as we speak blink

> w32file
> 168:		lID = pHDC

Except that this one is in w32gdi.ew and it doesn't matter anyhow as it
is validated prior to the assignment.

-- 
Derek Parnell
Melbourne, Australia

new topic     » goto parent     » topic index » view thread      » older message » newer message

Search



Quick Links

User menu

Not signed in.

Misc Menu