OpenEuphoria

Re: Empty procedure optimized out?

• Posted by Robert Craig <rds at RapidEuphoria.com> Nov 20, 2004
• 550 views

Juergen Luethje wrote:
> Robert Craig wrote:
> > By the way, this was too trivial for the release notes,
> > but I took out the warning about parameters declared but not used.
> 
> Previously, we could turn it off by using
>    without warning
> if we wanted to do so.
> 
> But now, we can *not* turn it on, if we want to do so.
> May I ask you please to reconsider this decision?

There's a line of code commented out in symtab.e line 510

or equal(vtype, "parameter") -- this is rarely a real problem

If you put that back in, eu.ex will report the warning.

You always have to strike a balance when reporting warnings.
You'd like to catch legitimatate problems, but you don't
want to generate a lot of false alarms. In this case I felt
the false alarm rate was maybe 100x the legitimate problem rate,
so I took it out. For instance, people might be calling a 
set of routines via call_proc() or call_func(), and some of 
those targetted routines might not use all of the arguments that 
are passed to them. 

The situation is different with other private variables. 
If you get a warning that one of those was declared
but not used, it's a simple matter to remove the useless
declaration. Those warnings remain. Most of them are legitimate.

Regards,
   Rob Craig
   Rapid Deployment Software
   http://www.RapidEuphoria.com