OpenEuphoria

Re: Mac text files and gets()

• Posted by Pete Lomax <petelomax at ??ueyonder.co.uk> Sep 14, 2007
• 509 views

Rob Craig wrote:
> Code breakage would be rare, provided you limit this feature to
> "r" mode, (I sometimes use gets() in binary "rb" mode). 

That gets my vote, however AFAICT, the code CChris is proposing to modify is:

	    // not stdin - faster loop
	    do { 
		TempBuff[i++] = c;
		if (c <= '\n') {
		    if (c == '\n') {
			break;
		    }
		    else if (c == EOF) {
			i--;
			break;
		    }
		}
		if (i == TEMP_SIZE)
		    break;
		c = getc(f);
	    } while (TRUE);

which, cmiiw, is not the cause of discarding the '\r', so this whole thread is
probably moot anyway...

CChris wrote:
>Only trick is that \r\r means two lines, \n\n too,
No probs.
> \r\n is one line
Looks to me like your suggested mod would just treat that as \n\n anyway
> and \n\r... well, left alone as unsupported.
FWIW, the way I would have attempted this is somthing like:

change:

    // get first char
    c = getc(f);

    if (c == EOF)
...
	    do { 
		TempBuff[i++] = c;
		if (c <= '\n') {
		    if (c == '\n') {
			break;
		    }

to:

    // get first char
    c = getc(f);

    if (c == EOF)

    else if (c==skippable) {
       c=getc(f);
       skippable=EOF   \\ put back to initial state
       }
...
	    do { 
		TempBuff[i++] = c;
		if (c <= '\r') {
		    if (c == '\n') {
                        skippable = '\r'
			break;
		    }
		    if (c == '\r') {
                        c = '\n';
                        skippable = '\n'
			break;
		    }

I would expect any cost this might have to be well under 4% for the average text
file, but of course that would neeed to be verified. Plus the new var skippable
would best be file-specific.

Regards,
Pete