OpenEuphoria

Re: Couple of minor win32lib tweaks

• Posted by CChris <christian.cuvier at a?ricultu?e.gouv.fr> Jan 22, 2008
• 477 views

Pete Lomax wrote:
> 
> 
> I noticed these today:
> 
> In getOpenFileName,
> }}}
<eucode>
>     flags = w32fetch( ofn, ofnFlags)
>     if w32Func(xGetOpenFileName, {ofn}) then
> </eucode>
{{{

> The first line is unnecessary.
> 

Will be deleted.

> In getEuVersion()
> }}}
<eucode>
>     s1=getenv("EUDIR")
>     if not length(s1) then
> 	s1=getenv("EUINC")
> 	if not length(s1) then
> </eucode>
{{{

> should be:
> }}}
<eucode>
>     s1=getenv("EUDIR")
>     if atom(s1) or not length(s1) then
> 	s1=getenv("EUINC")
> 	if atom(s1) or not length(s1) then
> </eucode>
{{{

> While I am probably unique in not having EUDIR set, EUINC is supposed to be
> optional, according to the docs.
> 

Looks like an old version, the one I have here says

s1=getenv("EUDIR")
    if compare(s1,"")<=0 then

and likewise for EUINC. 

Since win32lib will no longer test for the version of the interpreter starting
with the next release (any release of the lib will be compatible with the current
official version of interpreter, without striving for backward compatibility with
earlier versions), the whole version.e will vanish from the distro anyway. See
http://www.openeuphoria.org/EUforum/m18536.html
and the very few replies it got.

The soon-to-be 70.4 is compatible with Eu 2.3 and late, with the exception of
two task_yield() statements. There will be more $ and find_from()s in future
releases.

CChris

> Regards,
> Pete