OpenEuphoria

2. Re: Win32lib 0.60.6 and Judith Evans IDE (how to make it work)

• Posted by cklester <cklester at yahoo.com> Feb 09, 2005
• 504 views

Sascha Zindel wrote:
> 
> When i looked into the forum entries, i found that there was a discussion
> about Win32lib 0.60.6 and Judith Evans IDE regarding problems with the Form
> Design Window. I am using Windows XP and have the same problem.
> 
> The correct code should be:
>     -- find the parent window

What file is the code in? I couldn't find it in win32lib.ew.

-=ck
"Programming in a state of EUPHORIA."
http://www.cklester.com/euphoria/

4. Re: Win32lib 0.60.6 and Judith Evans IDE (how to make it work)

• Posted by Derek Parnell <ddparnell at bigpond.com> Feb 09, 2005
• 485 views
• Last edited Feb 10, 2005

Sascha Zindel wrote:
> 
> Hello,
> i have been away for a few months.
> 
> When i looked into the forum entries, i found that there was a discussion
> about Win32lib 0.60.6 and Judith Evans IDE regarding problems with the Form
> Design Window. I am using Windows XP and have the same problem.
> 
> The solution posted by Derek did not work on my PC. This has been stated by
> others in the forum.
> 
> So i took a small look at the code and found out that one return value
> incorrect.
> 
> The correct code should be:
>     -- find the parent window
>     if (id <= 0) or (ctrl_Parent[id] = 0) then 
>         -- The specified control has no parent.
>         -- the value below was 0, but it should be id 
>         return id
>     end if
> 
>     -- loop until I hit top of the tree or a 'window'-type control.
>     while id and (ctrl_Type[id] != Window) and (isTopLevelWindow(id) =
> w32False) do
>         -- move up
>         id = ctrl_Parent[ id ]
>     end while
>     return id
> end function
> 
> After implementing this change i started the IDE and .. surprise .. it works
> as it should.
> 
> I do not know if somebody else already found a solution for this, but maybe
> someone could try this out and let me know if everything works well on other
> pcs (and OS) as well.

Sorry to disagree with you guys, but your 'fix' is not the correct one. Even
though it might repair the use of the IDE, it is not the correct way to
fix the problem.

The findParentWindow() function is working correctly. It is *meant* to
return zero if the id does not have a parent window. I suspect that the
function is not being used correctly elsewhere in the win32lib, probably
the stuff that handles focus setting.

The version in 0.60.6 had a bug; namely it did what you have now 'fixed'
it to do. That was wrong. 

-- 
Derek Parnell
Melbourne, Australia
irc://irc.sorcery.net:9000/euphoria

6. Re: Win32lib 0.60.6 and Judith Evans IDE (how to make it work)

• Posted by "Sascha Zindel" <s.zindel at gmx.de> Feb 09, 2005
• 469 views
• Last edited Feb 10, 2005

Derek,

thanx for the info. Still funny because everything else seems to work and
from a short view to 0.60.4 i got the impresson that 0 might be correct.

Since i was away for a while, i would like to know if you still update the
code of win32lib or not?

In between i take your suggestion and try to find out what exactly happens
in the focus code.

Did i miss something else? It seems as if Judith is not doing any work on
the IDE anymore....

Greetings,
Sascha

> 
> 
> posted by: Derek Parnell <ddparnell at bigpond.com>
> 
> Sascha Zindel wrote:
> > 
> > Hello,
> > i have been away for a few months.
> > 
> > When i looked into the forum entries, i found that there was a
> discussion
> > about Win32lib 0.60.6 and Judith Evans IDE regarding problems with the
> Form
> > Design Window. I am using Windows XP and have the same problem.
> > 
> > The solution posted by Derek did not work on my PC. This has been stated
> by
> > others in the forum.
> > 
> > So i took a small look at the code and found out that one return value
> > incorrect.
> > 
> > The correct code should be:
> >     -- find the parent window
> >     if (id <= 0) or (ctrl_Parent[id] = 0) then 
> >         -- The specified control has no parent.
> >         -- the value below was 0, but it should be id 
> >         return id
> >     end if
> > 
> >     -- loop until I hit top of the tree or a 'window'-type control.
> >     while id and (ctrl_Type[id] != Window) and (isTopLevelWindow(id) =
> > w32False) do
> >         -- move up
> >         id = ctrl_Parent[ id ]
> >     end while
> >     return id
> > end function
> > 
> > After implementing this change i started the IDE and .. surprise .. it
> works
> > as it should.
> > 
> > I do not know if somebody else already found a solution for this, but
> maybe
> > someone could try this out and let me know if everything works well on
> other
> > pcs (and OS) as well.
> 
> Sorry to disagree with you guys, but your 'fix' is not the correct one.
> Even
> though it might repair the use of the IDE, it is not the correct way to
> fix the problem.
> 
> The findParentWindow() function is working correctly. It is *meant* to
> return zero if the id does not have a parent window. I suspect that the
> function is not being used correctly elsewhere in the win32lib, probably
> the stuff that handles focus setting.
> 
> The version in 0.60.6 had a bug; namely it did what you have now 'fixed'
> it to do. That was wrong. 
> 
> -- 
> Derek Parnell
> Melbourne, Australia
> irc://irc.sorcery.net:9000/euphoria
> 
> 
> 
> 

-- 
Lassen Sie Ihren Gedanken freien Lauf... z.B. per FreeSMS
GMX bietet bis zu 100 FreeSMS/Monat: http://www.gmx.net/de/go/mail

8. Re: Win32lib 0.60.6 and Judith Evans IDE (how to make it work)

• Posted by Derek Parnell <ddparnell at bigpond.com> Feb 10, 2005
• 492 views
• Last edited Feb 11, 2005

Sascha Zindel wrote:
> 
> Hello again!
> 
> After Derek pointed out that the function findParentWindows works fine with=
> 
> his patch applied,
> i took a closer look at the fDo..... Routines.

Thanks Sascha. I'll incorporate your fixes into the library.

-- 
Derek Parnell
Melbourne, Australia
irc://irc.sorcery.net:9000/euphoria

10. Re: Win32lib 0.60.6 and Judith Evans IDE (how to make it work)

• Posted by Ferlin Scarborough <ferlin1 at bellsouth.net> Feb 11, 2005
• 538 views

Sascha Zindel wrote:
> 
> Hello again!
> 
> After Derek pointed out that the function findParentWindows works fine with=
> 
> his patch applied,
> i took a closer look at the fDo..... Routines.
> 
> Since findParentWindows can return a 0 if no parentWindow is existing, all
> sequence handling
> should be verified to not access sequence[0].
> From what i found out, Derek already considered this in some calls, but not
> in all the necessary ones.
> 
> The following changes need to applied to Win32Lib 0.60.6 to work properly
> with Judith Evans IDE
> and consider Dereks latest patch to findCurrentWindows (and hopefully not
> break anything else ->
> Derek, could you check this and tell me whether this is the right track to
> follow?)
> 
> Modify findCurrentWindows
> -------------------------
> line 13579:
>     -- find the parent window
>     if (id <= 0) or (ctrl_Parent[id] = 0) then
>         -- The specified control has no parent
>         return 0
>     end if
>     -- loop until I hit top of the tree or a Window control.
>     while id and (ctrl_Type[id] != Window) and (isTopLevelWindow(id) =
> w32False) do
>         -- move up
>         id = ctrl_Parent[id]
>     end while
>     return id
> end function
> 
> 
> Modify in function fDoMouse
> ---------------------------
> line 31247:
> if (lParent != 0 and sequence(ctrl_Mousetrap[lParent])) then
> 
> Modify in function fDoSetFocus
> 
> line 31393:
> if (lParentWindow != 0 and ctrl_Closed[lParentWindow] = 1) or (lParent =
> !=0
> and ctrl_Closed[lParent] = 1) then
> 
> Modify in function fDoKillFocus
> 
> Modify in function fDoCommand
> -----------------------------
> line 31655:
> if (lParent != 0 and ctrl_Type[lParent] = TabItem) then
> 
> On my system this patch works fine. I did intensive tests and compared the
> behaviour between 0.60.4 and 0.60.6. So far everything seems fine.
> 
> Greetings,
> Sascha Zindel
> 
Sascha,

I tried to make the above changes, and now the IDE will not run at all, I get
the following error.  I have listed the first few lines of ex.err below:

C:\EuPrograms\IDE\IDE18-22\win32lib.ew:31387 in function fDoSetFocus() 
subscript value 0 is out of bounds, reading from a sequence of length 18 
    id = 3
    hWnd = 4850276
    iMsg = 7
    wParam = 0
    lParam = 0
    pReturn = -2761
    lRC = {-9987}
    lProp = <no value>
    lParent = 0
    lParentWindow = 0
    lTempId = <no value>

Here is the code around line 31387 from Win32Lib.ew (v0.60.6)

----------------------------------------------------
function fDoSetFocus(integer id, atom hWnd, atom iMsg, atom wParam, atom lParam,
atom pReturn)
----------------------------------------------------
    sequence lRC
    sequence lProp

    integer lParent
    integer lParentWindow
    integer lTempId


    lRC = {kSubclassedMsg}
    lParent = findParent(id)

    lParentWindow = findParentWindow(id)

    -- Don't bother setting focus to a window that's going down.
    if ctrl_Destroyed[id] != 0 or ctrl_Destroyed[lParentWindow] != 0 then
        return lRC
    end if

    -- Check for special case of a control in a closed window that
    -- gets focus again!
if (lParentWindow != 0 and ctrl_Closed[lParentWindow] = 1) or (lParent !=0
    and ctrl_Closed[lParent] = 1) then
        if focus_current > 0 and focus_current != id then
            -- Reset focus on the last control that had an explicit set focus.
            setFocus(focus_current)
            return lRC
        end if
    end if

Did I miss something here?

Thanks.

Ferlin Scarborough

Learn To Program Games in Free Courses At
http://www.gameuniv.net

My Euphoria Home Page
http://mywebpage.netscape.com/shadetreesoft

12. Re: Win32lib 0.60.6 and Judith Evans IDE (how to make it work)

• Posted by Ferlin Scarborough <ferlin1 at bellsouth.net> Feb 11, 2005
• 496 views

Sascha Zindel wrote:
> 
> Hi Ferlin,
> 
> for some reason my mail client removed a line from my sent mail.
> In function fDoSetFocus you should also change line 31387 as follows:
> if ctrl_Destroyed[id] != 0 or (lParentWindow != 0 and
> ctrl_Destroyed[lParentWindow] != 0) then
> 
> After that your problem is solved.
> 
> Greetings,
> Sascha Zindel
> 
Sascha,

Thanks for the quick reply, since it is 3:17AM here now, I'll try it when I
get to work.

Later.

Ferlin Scarborough

Learn To Program Games in Free Courses At
http://www.gameuniv.net

My Euphoria Home Page
http://mywebpage.netscape.com/shadetreesoft