OpenEuphoria

2. Re: win32lib v0.60.2 available

• Posted by Martin Stachon <martin.stachon at tiscali.cz> Aug 11, 2004
• 391 views

Derek Parnell wrote:

>posted by: Derek Parnell <ddparnell at bigpond.com>
>
>See
>
>  http://www.users.bigpond.com/ddparnell/euphoria/euphoria.htm
>
>  
I found some  bugs in this release:

1. - Derek's Debug :)

diff -ur old\rttext.e new\rttext.e
--- old\rttext.e      Wed Aug 11 17:13:48 2004
+++ new\rttext.e       Wed Aug 11 13:29:22 2004
@@ -156,5 +156,3 @@
     end for
     return lMsg
 end function
-
-puts(1, FormatMsg("%1 %3, %2", {"Mr", "Derek", "Parnell"}))

2. - extractIcon(string) is broken

diff -ur old\win32lib.ew new\win32lib.ew
--- old\win32lib.ew   Wed Aug 11 10:39:50 2004
+++ new\win32lib.ew    Wed Aug 11 13:40:32 2004
@@ -14277,6 +14277,8 @@
             end if
             lIdx = Filename[2]-1
             Filename = Filename[1]
+        else
+            lType = 1
         end if
     end if
     lBufferL = w32acquire_mem(0, 8)

There are others, but I don't have the time to examine them right now.
It's a machine exception and weird window behaviour.

And, hello again, Euphoria!

    Martin

4. Re: win32lib v0.60.2 available

• Posted by Derek Parnell <ddparnell at bigpond.com> Aug 11, 2004
• 419 views

Martin Stachon wrote:
> 
> Derek Parnell wrote:
> 

[snip]

> 2. - extractIcon(string) is broken
> 
> diff -ur old\win32lib.ew new\win32lib.ew
> --- old\win32lib.ew   Wed Aug 11 10:39:50 2004
> +++ new\win32lib.ew    Wed Aug 11 13:40:32 2004
> @@ -14277,6 +14277,8 @@
>              end if
>              lIdx = Filename[2]-1
>              Filename = Filename[1]
> +        else
> +            lType = 1
>          end if
>      end if
>      lBufferL = w32acquire_mem(0, 8)
> 

I've posted a patch on the web site.

   http://www.users.bigpond.com/ddparnell/euphoria/win32lib_patches.htm

-- 
Derek Parnell
Melbourne, Australia

6. Re: win32lib v0.60.2 available

• Posted by Matt Lewis <matthewwalkerlewis at yahoo.com> Aug 11, 2004
• 409 views

Derek Parnell wrote:
> 
> Martin Stachon wrote:
> > 
> > 2. - extractIcon(string) is broken
> > 
> > diff -ur old\win32lib.ew new\win32lib.ew
> > --- old\win32lib.ew   Wed Aug 11 10:39:50 2004
> > +++ new\win32lib.ew    Wed Aug 11 13:40:32 2004
> > @@ -14277,6 +14277,8 @@
> >              end if
> >              lIdx = Filename[2]-1
> >              Filename = Filename[1]
> > +        else
> > +            lType = 1
> >          end if
> >      end if
> >      lBufferL = w32acquire_mem(0, 8)
> 
> Doesn't fail for me. What is your test code?
> 

Here you go:

include win32lib.ew

? extractIcon("euphoria.ico")
? extractIcon("not a real icon")

This displays two bugs.  The first is that you never set lType's value
if Filename is a simple string--that's what Martin was referring to.
The second shows that (even though it's documented as returning a UINT),
it returns -1 if you pass a bad filename (at least it does here, on Win2K).
This should either be corrected in w32shell.ew (define_c_func) or lCnt 
should be changed to an atom to prevent an integer overflow.

How you choose to report the error is up to you.  In the past, this seems
to have passed the result of ExtractIcon--which was zero, so we had a
silent failure that wouldn't cause any problems so long as other, valid,
icons were loaded (I found this by trying to load a nonexistent icon in
EDB--should switch over to XPMs like I have with wxEDB, but that's another
day's fight).  Now you're using ExtractIconEx, which is why, I suppose
we're having these new bugs.

Matt Lewis