1. Re: code reviews
Excellent. This is exactly what is required. I'm assuming you are concerned
about the performance of win32lib. I'll update the file with these
improvements plus a few other similar ones. As for the overheads (comments,
whitespace, long names,etc), I'm thinking we'll release two variants of the
library - one fully commented and "beautified", and one stripped down
version. Does anyone want to submit a utility to minimise a Euphoria source
file?
-----
cheers,
Derek Parnell
>-----Original Message-----
>From: Derek Parnell [mailto:dparnell at bigpond.net.au]
>Sent: Tuesday, August 29, 2000 12:54 PM
>To: derekp at solace.com.au
>Subject: code reviews
>
>
>...code reviews,,, what's that ?
>
>...around lines 11220, and 12350: ( if then what ? )
>
>if sendMessage( id, UDM_SETBUDDY, getHandle( buddy ), 0) then end if
>
>if sendMessage( id, UDM_SETRANGE, 0, pack_word( max, min )) then
>end if
>
>...around lines 15369, and 15430, ( or_all() what ? )
>
>ofn = buildDefaultOfn( id, fName, filters, or_all( {
> OFN_FILEMUSTEXIST } ) ) -- file must exist
>
>ofn = buildDefaultOfn( id, fName, filters, or_all( {
> OFN_OVERWRITEPROMPT } ) ) -- warn if exists
>
>
>...now, how about that extra 20k. of totally redundant space chars...
>...does the "Months" sequence make my point ?
>
>from_way_up_north_Wolf
>
