1. Bug in put_screen_char

I think there is a small typo in the DOS section of
 put_screen_char in image.e (Euphoria 2.2). Line 336:

        if overflow then

 should probably read:

        if overflow > 0 then

 or something similar.

 And to my fellow free-riders out there; it seems this small
 fix can be made without affecting the 'stamping' (no
 statement count... smile

 Thanks,
 Tor

new topic     » topic index » view message » categorize

2. Re: Bug in put_screen_char

On Wed, 7 Jun 2000 08:50:23 +0000, Tor Gausen wrote:

> I think there is a small typo in the DOS section of
> put_screen_char in image.e (Euphoria 2.2). Line 336:
>
>        if overflow then
>
> should probably read:
>
>        if overflow > 0 then
>
> or something similar.

Since 'overflow' will never be less than zero, the above statements are
equivalent.  (zero=false, non-zero=true)

-- Brian

new topic     » goto parent     » topic index » view message » categorize

3. Re: Bug in put_screen_char

Dear Brian,

> Since 'overflow' will never be less than zero, the above statements are
> equivalent.  (zero=false, non-zero=true)

Have you actually studied this or are you just making an
expert's qualified guess? blink

The problem is that 'overflow' is ALWAYS negative (necessarily
resulting in a slicing error), unless you are trying to put a
char outside the screen, in which case the clipping works just
fine!

But sometimes it's nice with chars INSIDE the screen too...

Thanks,
Tor

new topic     » goto parent     » topic index » view message » categorize

4. Re: Bug in put_screen_char

On Thu, 8 Jun 2000 09:01:44 +0000, Tor Gausen wrote:

>Dear Brian,
>
>> Since 'overflow' will never be less than zero, the above statements are
>> equivalent.  (zero=false, non-zero=true)
>
>Have you actually studied this or are you just making an
>expert's qualified guess? blink

Hmmm... I must have evaluated 'overflow' incorrectly.  Now I see your
point.

...nevermind...  8^)
-- Brian

new topic     » goto parent     » topic index » view message » categorize

5. Re: Bug in put_screen_char

Tor Gausen writes:
> The problem is that 'overflow' is ALWAYS negative (necessarily
> resulting in a slicing error), unless you are trying to put a
> char outside the screen, in which case the clipping works
> just fine!

OK, I got it finally. Thanks.
Yes, it's a bug. It should say:
           if overflow > 0 then ...
I'll fix it for the next release.
The bug is in the DOS32 version which is rarely
used since display_text_image() can be used instead.

Regards,
   Rob Craig
   Rapid Deployment Software
   http://www.RapidEuphoria.com

new topic     » goto parent     » topic index » view message » categorize

Search



Quick Links

User menu

Not signed in.

Misc Menu