OpenEuphoria

1. Phix: 64bit (-1) equal #ffffffffffffffff ?!

• Posted by andreasWagner 2 months ago
• 243 views

Hallo

To make it more clear i have put togheter this small codefile.

The function scan_com_ports() should return a list of available serial ports.
The function serial_open()
should open a serial port and return the handle or INVALID_HANDLE_VALUE(-1) if it fails

C:\TDM-GCC-64\x86_64-w64-mingw32\include>grep -i INVALID_HANDLE_VALUE *.* 
pdh.h:#define INVALID_HANDLE_VALUE ((HANDLE)((LONG_PTR)-1)) 
handleapi.h:#define INVALID_HANDLE_VALUE ((HANDLE) (LONG_PTR)-1) 

196 
11000100 
11111111111111111111111111111111 
 
224 
11100000 
11111111111111111111111111111111 
 
{"COM7:","COM8:"} 

But works not so nice with Phix 64bit:
If it fails,the function returns #ffffffffffffffff instead of (-1), isn't it the same?
The result on my Computer:

18446744073709551615 
1111111111111111111111111111111111111111111111111111111111111111 
1111111111111111111111111111111111111111111111111111111111111111 
 
18446744073709551615 
1111111111111111111111111111111111111111111111111111111111111111 
1111111111111111111111111111111111111111111111111111111111111111 
 
152 
10011000 
1111111111111111111111111111111111111111111111111111111111111111 
 
156 
10011100 
1111111111111111111111111111111111111111111111111111111111111111 
 
18446744073709551615 
1111111111111111111111111111111111111111111111111111111111111111 
1111111111111111111111111111111111111111111111111111111111111111 
 
18446744073709551615 
1111111111111111111111111111111111111111111111111111111111111111 
1111111111111111111111111111111111111111111111111111111111111111 
 
{"COM5:","COM6:","COM7:","COM8:","COM9:","COM10:"} 

include cffi.e 
 
constant kernel=open_dll("kernel32.dll") 
--REF: http://msdn.microsoft.com/en-us/library/aa363858(VS.85).aspx 
--constant iCreateFile = define_c_func(kernel,"CreateFileA",{C_INT,C_INT,C_INT,C_INT,C_INT,C_INT,C_INT},C_INT) 
sequence tStr=""" 

HANDLE CreateFileA( 
  _in_           LPCSTR                lpFileName, 
  _in_           DWORD                 dwDesiredAccess, 
  _in_           DWORD                 dwShareMode, 
  _in_           LPVOID                lpSecurityAttributes, 
  _in_           DWORD                 dwCreationDisposition, 
  _in_           DWORD                 dwFlagsAndAttributes, 
  _in_           HANDLE                hTemplateFile 
); 
""" 

 
set_unicode(0) 
constant iCreateFile=define_cffi_func(kernel,tStr) 
 
constant 
     GENERIC_READ    = #80000000, 
     GENERIC_WRITE   = #40000000, 
     OPEN_EXISTING   = 3 
                                    
-- open a serial port and return the handle or INVALID_HANDLE_VALUE(-1) if it fails 
global function serial_open(integer com) 
atom fn_val, pComm 
   pComm = allocate_string(sprintf("\\\\.\\com%d",com)) 
   fn_val = c_func(iCreateFile,{pComm, 
                    GENERIC_READ+GENERIC_WRITE, 
                    0, 
                    0, 
                    OPEN_EXISTING, 
                    0, 
                    0 
                    }) 
   free(pComm) 
    if equal(fn_val,#ffffffffffffffff) then 
--      fn_val=-1 --This helps with Phix 64bit, but i think it is an ugly hack,  
    end if 
   return fn_val                 
end function 
 
--REF: http://msdn.microsoft.com/en-us/library/ms724211.aspx 
--constant iCloseHandle = define_c_func(kernel,"CloseHandle",{C_UINT},C_INT) 
tStr=""" 

BOOL CloseHandle( 
  _in_ HANDLE hObject 
); 
""" 

set_unicode(0) 
constant iCloseHandle=define_cffi_func(kernel,tStr) 
 
global procedure serial_close(atom hCom) 
atom fn_val 
  fn_val = c_func(iCloseHandle,{hCom})    
end procedure 
 
function scan_com_ports() 
atom hcom 
sequence retval={} 
for i=5 to 10 do 
    hcom=serial_open(i) 
    if hcom>0  then 
        puts(1,sprintf("%d\n",hcom)) 
        puts(1,sprintf("%b\n",hcom)) 
        puts(1,sprintf("%b\n\n",-1)) --just to make sure I'am not completly confused 
        serial_close(i) 
        retval=append(retval,(sprintf("COM%d:",i))) 
    end if 
    end for 
return retval 
end function 
?scan_com_ports() 
wait_key() 

Maybe someone can enlighten me.

Maybe I should just continue with 32bit. For my small programs there is not really a need to support 64bit. This is not the first time I have come across such oddities. I just forgot about it.
Andreas

3. Re: Phix: 64bit (-1) equal #ffffffffffffffff ?!

• Posted by petelomax 2 months ago
• 182 views

    if equal(fn_val,#ffffffffffffffff) then 
--      fn_val=-1 --This helps with Phix 64bit, but i think it is an ugly hack,  
    end if 

I'll agree with you that is not pretty, but it is probably the best/safest way, and (esp with an "or #FFFFFFFF") protects you against the sign of c_func() results possibly getting flipped one day.
Of course, having got it to work at all, I am going to be exceeding cautious of making the slightest change to anything in that area, for fear of it all coming crashing down like a ton of bricks.
Should you think I have some special knowledge of whether INVALID_FILE_HANDLE is -1, #FFFFFFFF, #FFFFFFFFFFFFFFFF, (HANDLE)-1, (HANDLE)(LONG_PTR)-1, (1 << FFI::Platform::ADDRESS_SIZE) - 1, or something else entirely, you would be quite wrong. Even Raymond Chen, the oracle of all microsoft-related knowledge, has some disparaging words to say on the matter, NULL would have been better, but "it is what it is, and we cannot change history": https://devblogs.microsoft.com/oldnewthing/20040302-00/?p=40443