OpenEuphoria

2. Re: User32 And GDI32 Wrapper Feedback

• Posted by EUWX Jul 13, 2012
• 1734 views

I have not tried, but I looked at your code and it looks excellent.
without meaning to downgrade your effort, it is typical of the style of wrappers I have seen in this site, so it should work well.
If something does not work, blame Bill Gates because of changes in the never ending series of Windows versions.

4. Re: User32 And GDI32 Wrapper Feedback

• Posted by coconut Jul 18, 2012
• 1610 views

I fast look at user32.ew and found something doubtfull here:

procedure WinHelp(atom handle,sequence str,atom ex,atom ex2) 
	 
	 c_proc(xWinHelp,{handle,str,ex,ex2}) 
	 
end procedure 

You can't pass a string to a WIN32 API function. Windows knows nothing about euphoria sequence. this should be something like that:

procedure WinHelp(atom handle,sequence str,atom ex,atom ex2) 
atom pStr 
         pStr = allocate_string(str)	 
	 c_proc(xWinHelp,{handle,pStr,ex,ex2}) 
         free(pStr) 
	 
end procedure 
 

By the way I did a lot of win32 API wrapping in past years. Take a look at: win32 api wrappers. Others did alot of it too, look at Judith Evans IDE. WIN32 API is huge. You would better improve and expand what as already been done than starting all over.

This is not to critisize, this work is usefull.

Jacques

6. Re: User32 And GDI32 Wrapper Feedback

• Posted by mattlewis (admin) Jul 19, 2012
• 1504 views

procedure WinHelp(atom handle,sequence str,atom ex,atom ex2) 
atom pStr 
         pStr = allocate_string(str)	 
	 c_proc(xWinHelp,{handle,pStr,ex,ex2}) 
         free(pStr) 
	 
end procedure 

With euphoria 4.0, you can simplify this a bit so that you don't have to worry about memory management:

procedure WinHelp(atom handle,sequence str,atom ex,atom ex2) 
atom pStr 
	 c_proc(xWinHelp,{handle,allocate_string(str, 1),ex,ex2}) 
end procedure 

Adding the extra 1 to the allocate_string() call causes the pointer to be freed once there are no more euphoria references to it.

Matt

8. Re: User32 And GDI32 Wrapper Feedback

• Posted by ghaberek (admin) Jul 20, 2012
• 1411 views

procedure WinHelp(atom handle,sequence str,atom ex,atom ex2) 
atom pStr 
	 c_proc(xWinHelp,{handle,allocate_string(str, 1),ex,ex2}) 
end procedure 

I'm really loving this feature, by the way. Here's a neat trick for passing optional "text" parameters that also accept NULL. I used this a lot when wrapping Newt.

namespace newt 
public procedure PushHelpLine( object text = NULL ) 
    if sequence( text ) then text = allocate_string( text, 1 ) end if 
    c_proc( x_newtPushHelpLine, {text} ) 
end procedure 

So if you call newt:PushHelpLine() with no parameters, it passes NULL automatically, if you pass an atom (assumed to be a string pointer) it passes it through directly, and if you pass a sequence (a text string) it is allocated into memory, flagged for collection, and then passed to the function.

You could also pre-allocate your strings as constant pointers and let Euphoria clean them up when it's done, although I can't see a direct advantage to this one way or the other (unless you're using a lot of strings on a really really slow machine).

constant helpText = allocate_string( "This is my help text", 1 ) 
 
newt:Init(1) 
newt:PushHelpLine( helpText ) 
newt:WaitForKey() 
newt:Finished() 
 
-- helpText will be freed automatically when we're done 

-Greg

10. Re: User32 And GDI32 Wrapper Feedback

• Posted by ghaberek (admin) Jul 20, 2012
• 1365 views

So in that case I don't need to add the cleanup parameter? Good to know. I guess it always kind of worked that way, didn't it?

-Greg