OpenEuphoria

2. Re: Quick Poll: what is the correct indentation for ifdef?

• Posted by petelomax Mar 05, 2011
• 1848 views

Sorry, I forgot about things like this:

      ifdef WIN32 then 
          if c_func(xGetWindow,{}) then 
      elsedef 
          if int80(getwin) then 
      end ifdef 
              ... 
          end if 

If you try and treat ifdef as "part of the code", there is no proper indent for that...

4. Re: Quick Poll: what is the correct indentation for ifdef?

• Posted by DerekParnell (admin) Mar 06, 2011
• 1717 views

There is no right way to indent things. Everyone sees indentation differently.

I'd ask ... Align 'ifdef' at column 1? Yes/no

6. Re: Quick Poll: what is the correct indentation for ifdef?

• Posted by SDPringle Mar 07, 2011
• 1635 views

The first way is what I prefer. The options could be called: 'Indent defined word statements with other code' ot 'indent defined words separately'

Shawn Pringle

8. Re: Quick Poll: what is the correct indentation for ifdef?

• Posted by jeremy (admin) Mar 11, 2011
• 1483 views

Oh, also, I really try to keep the ifdefs to definitions for clarity. Some places I use it in code but most places I try to abstract. I know your code was a simple example and not really intended for real code, but to give an example I would have:

-- Application constants 
ifdef WINDOWS then 
    constant platform_name = "windows" 
elsedef 
    constant platform_name = "linux/bsd/osx/something else" 
end ifdef 
 
-- Application code 
while 1 do 
    puts(1, platform_name) 
end while 

If some logic needs to change deeply nested, I try to abstract it as well:

ifdef WINDOWS then 
    procedure alert(sequence msg) 
        win32:msgbox(msg) 
    end procedure 
elsedef 
    procedure alert(sequence msg) 
        puts(1, msg) 
    end procedure 
end ifdef 
 
while 1 do 
    if error then 
        alert("bad code") 
    end if 
end while 

instead of

while 1 do 
    if error then 
        ifdef WINDOWS then 
            win32:msgbox("bad code") 
        elsedef 
            puts(1, "bad code") 
        end ifdef 
    end if 
end while 

This makes me think out the code and make it more reusable. I know the above is a simple example, but having an alert() for windows, linux, os/x all different is good programming as it allows me to fix the alert or make it more platform centric very easily without affecting my code not related to displaying an alert message, for example my error detection/reporting code.

Thus, with the above style, I think that how to indent ifdefs becomes less of a problem as you do not tend to have deeply nested ifdefs. Once exception, of course, is ifdef DEBUG type structures.

Jeremy