OpenEuphoria.org
Ticket #8:
Replying to a deleted topic should return a sensible error.
-
Reported by
CoJaBo
Sep 09, 2009
Details
1. Comment by jimcbrown
Oct 01, 2010
Is this really a bug? If you reply to a deleted post, it makes sense that you'd create a brand new topic.
2. Comment by DerekParnell
Oct 25, 2010
It doesn't make sense to me. If I reply to a deleted post I'm probably doing something stupid so it should let me know.
3. Comment by jeremy
Oct 25, 2010
I think there are two problems here...
- I think Matt or You created a test post when the new system went live. I hit the reply button waiting for the original to be deleted. Once it was deleted, if I hit refresh on my Reply, I got a 500 error, presumably because it tried to query for the old Subject/Body but couldn't find it and didn't bother checking to see if it actually had data before it attempted to access the resulting query sequence.
- Orphaned posts, as CoJaBo said above. Say you have Msg 123, then a reply to that Msg 124, then a reply to 124 as 125... What happens if author of 123 then deletes his message? Should 124 and 125 be automatically deleted? I don't think so but it then makes them not appear in the main "Topic" list because the topic list queries for parent_id = 0.
4. Comment by euphoric
Oct 25, 2010
First, users should not be able to delete posts. They can clear it with Edit, but to delete it should remain solely a moderator's/admin's function.
Given that, if a mod/admin deletes a post, it should warn that it has children and if he proceeds, the post and its children will be removed. Upon confirmation, it should all go bye-bye. I don't see this being used often, but off-topic/spam/trolling threads can be summarily dismissed with extreme prejudice. IF the thread contains posts with valuable information, an admin can always go in and clear the post and replace with "Text removed by admin" or somesuch, although there will no doubt be remnants in child posts.
5. Comment by jeremy
Oct 25, 2010
Only forum moderators can delete a post. Looking at the code it does remove children. I added a message on the confirmation warning that replies will be removed as well.
6. Comment by jeremy
Oct 26, 2010
Bumped down to Normal severity as this occurs very, very little. Not minor because it is a crash.
GitHub