OpenEuphoria.org
Ticket #14:
Link tickets to svn commits automatically
-
Reported by
mattlewis
Sep 09, 2009
The ticket system should periodically check svn commit logs (or possibly have the information pushed to it) to check for matches to tickets.
If we come up with an easy way to reference other tickets (TICKET-13), then we could use the same markup or whatever in svn commit logs.
Details
1. Comment by jeremy
Sep 09, 2009
What would we do with the information found in SVN? Would we search for something such as "Fixes ticket:12" and then change the status to fixed and add the SVN comment in as a new comment or would it do something more or less?
2. Comment by mattlewis
Sep 10, 2009
No, I think status changes would still have to be manual. It's simply an informational thing. And it removes the need to put in ticket comments like: fixed in r1234.
Basically, what Jira does is assigns each ticket a unique identifier. You set up a project, and each issue just gets an autoincremented id (PROJECTNAME-1, PROJECTNAME-2, etc). so when you commit something to address a particular ticket, in the commit message, you just put that somewhere:
- The whatsit now correctly frobs the baz PROJECTNAME-1234
And then Jira it picks that up the next time it looks at svn. The way we have it configured, it tells you which repository the commit came from, the date/time, user, revision number, the full commit message, and the files changed/added/deleted.
It can make post-hoc analyses a lot easier, since you can find the code that was supposed to fix some bug (or whatever). I'm not sure how this would work with a DVCS (mainly because I've never used one), so maybe we should hold off on it for that reason alone.
3. Comment by jeremy
Sep 10, 2009
There is a place to enter the SVN revision number (or DVCS #) that will link to the svn change on SF.net, but that's all manual. I guess the SVN update system could just append the revision number into that field. If multiple revision numbers exist with the ticket:12 text, then it would just do 2780,2782,2789.
Is that what you're speaking of or does it actually attach a comment?
4. Comment by mattlewis
Sep 10, 2009
We've got the ability to link, so this is basically equivalent.
5. Comment by jeremy
Sep 10, 2009
Yes, but this is not automatic. Isn't this request to be automatic linking? That would be easy enough to accomplish.
6. Comment by mattlewis
Sep 10, 2009
Well, we either have to specify the ticket in the commit, or the revision in the ticket, and then we've made a link, so it's not completely automatic. The main thing was a way to link them together, and when I put this in, I think I didn't understand how the 'Fixed in SVN' function worked.
I won't stop you from adding it, but you've already put in the real functionality that I was interested in.
7. Comment by jeremy
Sep 10, 2009
It's nice to have it in both locations. In my commits, I always try to reference what ticket the commit is working on (if any). That way when we look at the SVN logs we can go look at the ticket for more info or when closing a ticket, I put the svn rev, so when looking at the ticket, I can go get the SVN diff. If we can eliminate one of these, the better
8. Comment by jeremy
Sep 10, 2009
Ha! 2774 was added automatically by the system, not by me!
9. Comment by jeremy
Sep 10, 2009
This is fixed and implemented. If you did not specify the SVN # when you closed the ticket, the auto update will catch it, assuming you add ticket:XYZ in your commit log.