1. Insolor as dev?

Forked from Re: gbonvehi as dev?

Insolor, would you like to be made a developer and be given access to commit the patch for ticket:898 (and other patches you may have or may create in the future)?

new topic     » topic index » view message » categorize

2. Re: Insolor as dev?

jimcbrown said...

Forked from Re: gbonvehi as dev?

Insolor, would you like to be made a developer and be given access to commit the patch for ticket:898 (and other patches you may have or may create in the future)?

Of course, I'll be glad

new topic     » goto parent     » topic index » view message » categorize

3. Re: Insolor as dev?

Insolor said...
jimcbrown said...

Forked from Re: gbonvehi as dev?

Insolor, would you like to be made a developer and be given access to commit the patch for ticket:898 (and other patches you may have or may create in the future)?

Of course, I'll be glad

Done. You should now be able to commit to https://scm.openeuphoria.org/hg/euphoria/

If you need a primer on how to use hg, see http://openeuphoria.org/wiki/view/Mercurial.wc

Welcome to the team!

new topic     » goto parent     » topic index » view message » categorize

4. Re: Insolor as dev?

jimcbrown said...
Insolor said...
jimcbrown said...

Forked from Re: gbonvehi as dev?

Insolor, would you like to be made a developer and be given access to commit the patch for ticket:898 (and other patches you may have or may create in the future)?

Of course, I'll be glad

Done. You should now be able to commit to https://scm.openeuphoria.org/hg/euphoria/

If you need a primer on how to use hg, see http://openeuphoria.org/wiki/view/Mercurial.wc

Welcome to the team!

Thank you! Are there any general workflow rules/recomendations?

new topic     » goto parent     » topic index » view message » categorize

5. Re: Insolor as dev?

Insolor said...

Thank you! Are there any general workflow rules/recomendations?

We don't really have a formal list... the only thing I can think of is, for a feature or fix to be added in the 4.0 line, to commit first into the 4.0 branch and then merge it into the default branch. I usually just commit a patch twice, once to each branch, though, instead of merging.

new topic     » goto parent     » topic index » view message » categorize

6. Re: Insolor as dev?

jimcbrown said...
Insolor said...

Thank you! Are there any general workflow rules/recomendations?

We don't really have a formal list... the only thing I can think of is, for a feature or fix to be added in the 4.0 line, to commit first into the 4.0 branch and then merge it into the default branch. I usually just commit a patch twice, once to each branch, though, instead of merging.

Merging has the advantage of letting hg know what's going on.

The most important thing is to update the release notes with your change.

Matt

new topic     » goto parent     » topic index » view message » categorize

7. Re: Insolor as dev?

mattlewis said...
jimcbrown said...

I usually just commit a patch twice, once to each branch, though, instead of merging.

Merging has the advantage of letting hg know what's going on.

And it's an important one. I'm just really bad at this.

mattlewis said...

The most important thing is to update the release notes with your change.

Another thing I'm bad at.

new topic     » goto parent     » topic index » view message » categorize

8. Re: Insolor as dev?

Hi

i do not wan't to disturb but
Please have a look at http://openeuphoria.org/pastey/245.wc#3624

Andreas

new topic     » goto parent     » topic index » view message » categorize

9. Re: Insolor as dev?

andi49 said...

Hi

i do not wan't to disturb but
Please have a look at http://openeuphoria.org/pastey/245.wc#3624

Andreas

Ouch! That looks like a real pain to deal with. sad

Do we have to do that? Maybe it's not a big deal to report 8.0 when running under 8.1, especially when we're not using or especially supporting the new apis there?

new topic     » goto parent     » topic index » view message » categorize

10. Re: Insolor as dev?

jimcbrown said...
andi49 said...

Hi

i do not wan't to disturb but
Please have a look at http://openeuphoria.org/pastey/245.wc#3624

Andreas

Ouch! That looks like a real pain to deal with. sad

Do we have to do that? Maybe it's not a big deal to report 8.0 when running under 8.1, especially when we're not using or especially supporting the new apis there?

Hi

knowing your OperatingSystem is not an useless information (maybe at the moment it doesn't matter if it is 8.0 or 8.1)
The change in 'eu.manifest' is trivial.

I have built a Eu4.1 with this manifest and it didn't hurt WinXP and gives correct values for Win8.1. I can't test for Vista and WIn7.
(and i do not really care about any Windows Version before WinXP, but I'am a little selfish ;)

Andreas

new topic     » goto parent     » topic index » view message » categorize

11. Re: Insolor as dev?

andi49 said...
jimcbrown said...

Ouch! That looks like a real pain to deal with. sad

The change in 'eu.manifest' is trivial.

Ah, ok, in that case nevermind. If it's simple, then we should definitely add it.

new topic     » goto parent     » topic index » view message » categorize

12. Re: Insolor as dev?

andi49 said...

Hi

i do not wan't to disturb but
Please have a look at http://openeuphoria.org/pastey/245.wc#3624

Andreas

Yes, with the patch Win8.1 is reported as Win8. It's left to learn where to place this manifest :) This will be done, of course.

Moreover, uname() needs extra improvements (i.e. using OSVERSIONINFOEX structure instead of OSVERSIONINFO) to distinguish workstation and server versions of OSes (eg. Win7 and Win2008). I will work on it soon.

new topic     » goto parent     » topic index » view message » categorize

13. Re: Insolor as dev?

Insolor said...

Yes, with the patch Win8.1 is reported as Win8. It's left to learn where to place this manifest :) This will be done, of course.

Maybe,

http://scm.openeuphoria.org/hg/euphoria/file/0c3ed4712b6e/source/eu.manifest

new topic     » goto parent     » topic index » view message » categorize

14. Re: Insolor as dev?

andi49 said...
Insolor said...

Yes, with the patch Win8.1 is reported as Win8. It's left to learn where to place this manifest :) This will be done, of course.

Maybe,

http://scm.openeuphoria.org/hg/euphoria/file/0c3ed4712b6e/source/eu.manifest

I see, finally it gets into an executable. Thank you for help.

new topic     » goto parent     » topic index » view message » categorize

15. Re: Insolor as dev?

Tip:

manifest = substitute_all(manifest,"\"x86\"","\"amd64\"")

Seems to make 64-bit executables /alot/ happier.

HTH,
Pete

Edit: I just noticed that file has "*" under common controls, I've not tried that, so maybe you can ignore this.

new topic     » goto parent     » topic index » view message » categorize

Search



Quick Links

User menu

Not signed in.

Misc Menu