OpenEuphoria

Euphoria Ticket #661: minGW euc source/buildsys.e should link to comctrl32 not comdlg32

• Reported by ne1uno May 05, 2011
• 7 comments

# HG changeset patch 
# User ne1uno <ne1uno@users.sourceforge.net> 
# Date 1304352000 14400 
# Branch 4.0 
# Node ID b74df49afe47881d889aae3dcd3e67d280ab5e12 
# Parent  f606b0ae83dd0cdf222e715d46c2b38e98824db1 
fix buildsys to use comctrl32 instead of comdlg32 like the makefiles 
 
diff -r f606b0ae83dd -r b74df49afe47 source/buildsys.e 
--- a/source/buildsys.e	Mon May 02 11:56:01 2011 -0400 
+++ b/source/buildsys.e	Mon May 02 12:00:00 2011 -0400 
@@ -432,7 +432,7 @@ 
 			elsif TOSX then 
 				l_flags &= " -lresolv" 
 			elsif TWINDOWS then 
-				l_flags &= " -mno-cygwin -lws2_32 -lcomdlg32"				 
+				l_flags &= " -mno-cygwin -lws2_32 -lcomctl32"				 
 			end if 
 			 
 			-- input/output 
@@ -465,7 +465,7 @@ 
 				end if 
 			end if 
  
-			l_flags &= sprintf(" FILE %s LIBRARY ws2_32 LIBRARY comdlg32", { user_library }) 
+			l_flags &= sprintf(" FILE %s LIBRARY ws2_32 LIBRARY comctl32", { user_library }) 
 			 
 			 
 			-- resource file, executable file  

Details

1. Comment by mattlewis May 05, 2011

See: hg:euphoria/rev/5c63702c9ffc

changeset: 4886:5c63702c9ffc branch: debugger user: Matt Lewis date: Thu May 05 14:45:25 2011 -0400 files: source/buildsys.e description:

• fix buildsys to link correct windows dll for translated programs
• fixes ticket 661

2. Comment by mattlewis May 05, 2011

See: hg:euphoria/rev/b2d1b87e91c0

changeset: 4887:b2d1b87e91c0 branch: debugger user: Matt Lewis date: Thu May 05 14:45:35 2011 -0400 files: docs/release/4.0.3.txt description:

• release notes for ticket 661

3. Comment by mattlewis May 05, 2011

See: hg:euphoria/rev/1f1d9358be0d

changeset: 4888:1f1d9358be0d branch: 4.0 parent: 4882:f557348317e8 user: Matt Lewis date: Thu May 05 14:46:53 2011 -0400 files: docs/release/4.0.3.txt source/buildsys.e description:

• fix ticket 661 in 4.0 branch

4. Comment by ne1uno May 11, 2011

tried to reply to commit msg but it's read only

Date: Wed, 11 May 2011 13:02:52 -0400 
Subject: Re: [Rapideuphoria-commits] euphoria: * removed some 4.1 code that was unintentionally added 
buildsys.e 
                       c_flags &= sprintf(" -c -w -fsigned-char -O2 -m%d -I%s -ffast-math", 
-                               { sizeof( C_POINTER ) * 8, get_eucompiledir() }) 
+                               { get_eucompiledir() }) 
 
should'nt this be: 
+                               { 32, get_eucompiledir() }) 
 

5. Comment by mattlewis May 12, 2011

Oops. My editor had been upgraded, and some settings got reset (namely, checking for external modifications), and didn't get all of the resulting junk cleaned up.

See hg:euphoria/rev/9af47aa6ef56 for the update.

6. Comment by SDPringle Jul 02, 2011

This is fixed.

7. Comment by mattlewis Jul 13, 2011

See: hg:euphoria/rev/751e95981026

changeset: 5062:751e95981026 branch: 4.0 parent: 5060:1f136c2188ca user: Matt Lewis date: Wed Jul 13 05:44:11 2011 -0400 files: docs/release/4.0.4.txt description:

• ticket 661 was fixed in (and included in release notes for) 4.0.3

Include: