Euphoria
Ticket #893:
map loading fails in some specific cases
-
Reported by
SDPringle
May 10, 2014
As reported by gimlet in his post some hand crafted maps could fail to load correctly with load_map.
http://openeuphoria.org/forum/124274.wc#124274
An example test file was:
":=" = "assignment"
"==" = "comparison"
",$" = "placeholder"
", $" = "erroneous - no spaces"
"--" = "comment ---- to end of line"
Details
1. Comment by jimcbrown
Jun 07, 2014
See: hg:euphoria/rev/c5dc17911d1d
changeset: 6219:c5dc17911d1d tag: tip user: Jim C. Brown date: Sat Jun 07 10:07:55 2014 -0400 files: include/std/map.e description:
- Quick fix for ticket:893
- Does not attempt to deal with the hand-generated test map file, but fixes the case where a map is saved with save_map() and then reloaded with load_map().
2. Comment by jimcbrown
Jun 07, 2014
See: hg:euphoria/rev/71da9185edd6
changeset: 6220:71da9185edd6 tag: tip user: Jim C. Brown date: Sat Jun 07 11:15:30 2014 -0400 files: include/std/map.e description:
- Another quick fix for ticket:893
- Try to intelligently handle some cases involving the use of non alphanumeric characters inside of quotes. This appears to deal with the hand-generated map file.
3. Comment by SDPringle
Jul 05, 2014
See: hg:euphoria/rev/84819eb04f10
changeset: 6243:84819eb04f10 branch: alternative_literals parent: 6241:3e6951c7f4cc parent: 6220:71da9185edd6 user: Shawn Pringle <shawn.pringle@gmail.com> date: Sat Jul 05 10:46:17 2014 -0300 description:
- mege fixes to ticket 893 into this branch
4. Comment by SDPringle
Jul 05, 2014
See: hg:euphoria/rev/01509a9181d1
changeset: 6245:01509a9181d1 tag: tip user: Shawn Pringle <shawn.pringle@gmail.com> date: Sat Jul 05 15:12:52 2014 -0300 files: tests/893.map tests/t_893.e description:
- added unit tests for ticket 893
5. Comment by SDPringle
Jan 24, 2015
See: hg:euphoria/rev/1087da3b684c
changeset: 6285:1087da3b684c branch: 4.0 user: Jim C. Brown date: Sat Jun 07 10:07:55 2014 -0400 files: include/std/map.e description:
- Quick fix for ticket:893
- Does not attempt to deal with the hand-generated test map file, but fixes the case where a map is saved with save_map() and then reloaded with load_map().
6. Comment by SDPringle
Jan 24, 2015
See: hg:euphoria/rev/107b090089ed
changeset: 6286:107b090089ed branch: 4.0 user: Jim C. Brown date: Sat Jun 07 11:15:30 2014 -0400 files: include/std/map.e description:
- Another quick fix for ticket:893
- Try to intelligently handle some cases involving the use of non alphanumeric characters inside of quotes. This appears to deal with the hand-generated map file.
7. Comment by SDPringle
Jan 24, 2015
See: hg:euphoria/rev/34c69ee1af86
changeset: 6289:34c69ee1af86 branch: 4.0 tag: tip user: Shawn Pringle <shawn.pringle@gmail.com> date: Sat Jan 24 17:01:12 2015 -0300 files: docs/release/4.0.6.txt description:
- backport of ticket 893 to 4.0 added
8. Comment by jimcbrown
Jan 24, 2015
Wait, what happened to Derek's rewrite? Surely we want to get a real fix in, rather than just papering over the cracks.
9. Comment by SDPringle
Jan 25, 2015
I consider these changes "real" fixes. Is there a reason to keep this ticket open?
10. Comment by jimcbrown
Jan 25, 2015
Matt or Derek, can you chime in here? I thought gimlet had identified issues in the code itself which required Derek to begin a rewrite of the std/map.e code from scratch.
11. Comment by jimcbrown
Feb 17, 2015
It's almost been a month and no one has chimed in. I assume that everyone else thinks that these fixes are sufficient and that a rewrite is no longer necessary - or else Derek snuck in his changes when I wasn't looking.
Either way, I think we can close this ticket out. Let's get rid of it before it hits the one year mark.
12. Comment by SDPringle
Oct 20, 2015
This was fixed but not confirmed for a long time... marking fixed.