Re: sort constants confusing

new topic     » goto parent     » topic index » view thread      » older message » newer message
_tom said...

Can we standardize on rising and falling?

Let's not. There is nothing whatsoever wrong with any of the terms/constant names as given, the problem is just the implication that they are somehow different.

Having four constants implies (to my tiny brain) that there are four separate meanings, when in fact there are only two, which is as clear as can be in the source, but not in the documentation.

It is fair to say that someone would only ever notice this if they had not just looked at the source file.

Assuming that it is not practical to change eu2doc (or whatever it is called) to stop it from ripping out the "=" parts,
I think the simplest solution would just be to change, in std/sort.e itself:

--** The normal sort order used by the custom comparison routine. 
NORMAL_ORDER = ASCENDING, 

to

--** The normal sort order used by the custom comparison routine. (same as ASCENDING) 
NORMAL_ORDER = ASCENDING, 

and

--** Reverses the sense of the order returned by a custom comparison routine. 
REVERSE_ORDER = DESCENDING 

to

--** Reverses the sense of the order returned by a custom comparison routine. (same as DESCENDING) 
REVERSE_ORDER = DESCENDING 

I retract my suggestion to "bin two of em"

Pete

new topic     » goto parent     » topic index » view thread      » older message » newer message

Search



Quick Links

User menu

Not signed in.

Misc Menu