Euphoria
Ticket #721:
t_filesys.e driver letter case difference
-
Reported by
SDPringle
Oct 28, 2011
I am noticing t_filesys.e test failures in the case of the drive letter. This happens on Windows Vista. To users trying out the tests, this will look like we didn't get filesys.e right.
Details
1. Comment by mattlewis
Oct 28, 2011
Yes, I get this a lot, too. I guess the question is whether we should update the test or the library?
2. Comment by SDPringle
Dec 09, 2011
This may have disappeared due to updates in Windows Vista. Perhaps we should mark this as fixed.
3. Comment by mattlewis
Dec 09, 2011
I still get this on platforms other than Vista. I think we should probably have a smarter test on windows (where we have to deal with drive letters).
4. Comment by SDPringle
Dec 17, 2011
It seems that someone had modified the tests such that they would get 100% success on t_filesys.e by substituting a hard coded capital C to the actual drive letter. When I ran the tests from a drive other than C, the tests failed. What the differences come from are current_dir() and canonical_path do not agree. It is current_dir() that sets all drive letters to capital letters. It seems the best solution is to leave the case as is.
5. Comment by SDPringle
Dec 17, 2011
See: hg:euphoria/rev/df4781b6ba44
changeset: 5370:df4781b6ba44 branch: 4.0 tag: tip parent: 5367:33cc69578863 user: Shawn Pringle <shawn.pringle@gmail.com> date: Sat Dec 17 12:53:13 2011 -0300 files: include/std/filesys.e source/be_machine.c tests/t_filesys.e description:
- changes current_dir to not change the case of the drive.
- added tests to std/filesys.e to test that it will correct the case of the drive letter.
- modified std/filesys.e to modify the case of the drive letter when the CORRECT flag is present.
- fixes ticket 721
6. Comment by SDPringle
Dec 21, 2011
See: hg:euphoria/rev/7a4ac8bfe2ff
changeset: 5395:7a4ac8bfe2ff branch: 4.0 tag: tip parent: 5390:8b1a70eda7a3 user: Shawn Pringle <shawn.pringle@gmail.com> date: Wed Dec 21 17:45:39 2011 -0300 files: docs/release/4.0.4.txt tests/t_filesys.e description:
- updated release notes for ticket 721
- uncommented out some code for the test
GitHub